Github user rogersjeffreyl commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/38#discussion_r67582020
  
    --- Diff: parser/preprocessed/SqlLexer_gen.cpp ---
    @@ -8,8 +8,8 @@
     
     #define FLEX_SCANNER
     #define YY_FLEX_MAJOR_VERSION 2
    -#define YY_FLEX_MINOR_VERSION 6
    -#define YY_FLEX_SUBMINOR_VERSION 0
    +#define YY_FLEX_MINOR_VERSION 5
    --- End diff --
    
    @pateljm Right now the travis in apache runs on a older version of FLEX. 
Hence it uses the files present in parser/preprocessed by default.  Any one who 
adds new tokens/rules to the parser has to run parser/genfiles.sh  and check 
the generated files in  for the changes to work.  We should be making sure that 
this is a part of the documentation for the parser workflow. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to