Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/58#discussion_r71233398
--- Diff: query_optimizer/resolver/Resolver.cpp ---
@@ -2670,7 +2681,8 @@ E::ScalarPtr Resolver::resolveFunctionCall(
}
// Make sure that the aggregate can apply to the specified argument(s).
- if (!aggregate->canApplyToTypes(argument_types)) {
+ if ((aggregate != nullptr && !aggregate->canApplyToTypes(argument_types))
--- End diff --
Code style for the bool expressions:
https://google.github.io/styleguide/cppguide.html#Boolean_Expressions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
