Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/90
Hi @rathijit
Thanks for summarizing the review discussion. The current travis failure is
only for GCC and looks like it doesn't like signed and unsigned comparison
(Clang is fine with it).
Is there a way we can address the second point in the future work - Stop
calling finalize for non-avg aggregates in the same PR? If each aggregate
handle can tell its type, we can detect it much earlier and not even call the
finalize hash table call on that handle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
