Github user hbdeshmukh commented on the issue:
https://github.com/apache/incubator-quickstep/pull/103
Based on a discussion between @tarunbansal, @hakanmemisoglu and I - we
noted two things:
1. Logging error messages to std::cout could be unhelpful when there are
multiple threads trying to load the data. The error messages will get mixed up
with each other. For now, @tarunbansal decided to log the error messages (using
GLOG) to the log file. Later, we can summarize the error messages using
thread-private buffers and emit them at the end of each work order execution.
2. @tarunbansal will look at how the current testing framework for TextScan
operator and add tests with corrupt input tuples. The testing would involve
loading an input with some corrupt tuples and verifying if the correct tuples
got inserted.
Once the above comments are addressed and the commits are squashed in one,
we will be good to go. Thanks @pateljm @zuyu for your inputs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
