GitHub user hbdeshmukh opened a pull request:
https://github.com/apache/incubator-quickstep/pull/120
Store handle count in FastSeparateChainingHashTable
- Using handles_ vector directly in FastSeparateChainingHashTable can
cause problems. One example is a distinctify hash table which doesn't
accept any payload. In this case, the reference to handles_ vector
becomes garbage after the constructor gets executed. Therefore to
avoid faults about accessing an invalid reference, we use the number
of handles as a guarding mechanism.
- Verified by reducing the hash table size artificially, so as to forcing a
``resize()`` operation. The ``destroyPayload()`` function gets called in
``resize()``. The fix in this PR fixes the behavior of ``destroyPayload``
function.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-quickstep
fix-emptypayload-fastsephashtable
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-quickstep/pull/120.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #120
----
commit 9c32ea45c5971568fae3d611a0fc9d963d7501bf
Author: Harshad Deshmukh <[email protected]>
Date: 2016-10-21T21:15:53Z
Remember handle count in FastSeparateChainingHashTable
- Using handles_ vector directly in FastSeparateChainingHashTable can
cause problems. One example is a distinctify hash table which doesn't
accept any payload. In this case, the reference to handles_ vector
becomes garbage after the constructor gets executed. Therefore to
avoid faults about accessing an invalid reference, we use the number
of handles as a guarding mechanism.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
