Github user zuyu commented on a diff in the pull request:
https://github.com/apache/incubator-quickstep/pull/155#discussion_r95023239
--- Diff: relational_operators/SaveBlocksOperator.hpp ---
@@ -56,13 +57,16 @@ class SaveBlocksOperator : public RelationalOperator {
* @brief Constructor for saving only modified blocks in a relation.
*
* @param query_id The ID of the query to which this operator belongs.
+ * @param relation The relation whose blocks will be saved.
* @param force If true, force writing of all blocks to disk, otherwise
only
* write dirty blocks.
**/
explicit SaveBlocksOperator(const std::size_t query_id,
--- End diff --
We could remove the `explicit` keyword.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---