Github user hbdeshmukh commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/295#discussion_r138950122
  
    --- Diff: query_optimizer/tests/logical_generator/Create.test ---
    @@ -63,6 +67,15 @@ PARTITION BY HASH(attr1, attr2, attr3, attr4, attr5, 
attr6) PARTITIONS 4;
     --
     TopLevelPlan
     +-plan=CreateTable[relation=foo]
    +| +-partition_scheme_header=ProtoDescription
    +| | +-Property=ProtoProperty[Property=partition_type,Value=hash]
    +| | +-Property=ProtoProperty[Property=num_partitions,Value=4]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=0]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=1]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=2]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=3]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=4]
    +| | +-Property=ProtoProperty[Property=partition_attr_id,Value=5]
    --- End diff --
    
    Is it feasible to get the attribute names instead of their value? That 
might be easier to understand and read. 


---

Reply via email to