Github user dylanpbacon commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/300#discussion_r140610972
  
    --- Diff: query_optimizer/strategy/Join.cpp ---
    @@ -371,6 +373,7 @@ void Join::addHashJoin(const logical::ProjectPtr 
&logical_project,
                               left_join_attributes,
                               right_join_attributes,
                               residual_predicate,
    +                          build_predicate,
    --- End diff --
    
    Agreed, less superfluous that way.


---

Reply via email to