[GitHub] incubator-quickstep pull request #328: QUICKSTEP-114 Upgrade cpplint

[zuyu]

Github user zuyu commented on a diff in the pull request:

    https://github.com/apache/incubator-quickstep/pull/328#discussion_r158370165
  
    --- Diff: storage/BasicColumnStoreValueAccessor.hpp ---
    @@ -108,25 +109,25 @@ class BasicColumnStoreValueAccessorHelper {
       }
     
       template <bool check_null>
    -  inline const void* getAttributeValue(const tuple_id tuple,
    +  inline const void* getAttributeValue(const tuple_id input_tuple,
    --- End diff --
    
    To be consistent with above, how about using `tid`?


---