Oh, no. The keyword "PR" is fine by me. Sorry for forgetting it.
Robby
On Thu, Jan 12, 2012 at 8:39 PM, Eli Barzilay <e...@barzilay.org> wrote:
> A few minutes ago, Sam Tobin-Hochstadt wrote:
>> I think you have to write "PR NNNN" to get that to work.
>>
>> On Thu, Jan 12, 2012 at 8:47 PM, Robby Findler
>> <ro...@eecs.northwestern.edu> wrote:
>> > Didn't my commit automatically do this?
>
> [Redirecting to dev]
>
> The script that scans the commit messages does require a "pr". The
> relevant piece of script is below, in case someone wants to suggest
> improvements. Adding "bug" as an alternative to "pr" is easy, but
> making it optional seems potentially dangerous. Maybe allow it but
> restrict numbers to exactly 5 digits? Actually, since it's in the
> same server anyway, it can just do its thing only for numbers that
> correspond to existing PRs. (I'm fine with doing that, but it bugs me
> to spend more time on something that everyone, me included, wants to
> eventually throw out.)
>
> grep -Eio '((clos(e[ds]|ing)|fix(ing|e[ds])?) )?\bpr ?[0-9]+' | \
> tr [:upper:] [:lower:] | \
> while read R; do
> if [[ "$R" =~ "^(clos|fix)?.*[^0-9]([0-9]+)" ]]; then
> if [[ -n "${BASH_REMATCH[1]}" ]]; then op="close_pr"
> else op="mention_pr"; fi
> pr="${BASH_REMATCH[2]}"
> url="${url_base}/commit/${rev:0:10}"
> "$op" "$pusher" "${pusher}@${pusher_domain}" "$pr" "$url"
> fi
> done
>
> --
> ((lambda (x) (x x)) (lambda (x) (x x))) Eli Barzilay:
> http://barzilay.org/ Maze is Life!
> _________________________
> Racket Developers list:
> http://lists.racket-lang.org/dev
_________________________
Racket Developers list:
http://lists.racket-lang.org/dev
