I would think that browser-like buttons are enough, and match the stack philosophy.
I also think that stacks are fine. If working with bookmarks suggest we want something else, we should explore this as a second step. Finally, I would hate to see these things saved in preference files. On Feb 3, 2012, at 1:04 PM, Robby Findler wrote: > If it an unordered list of lines that were bookmarked, then I'd use > highlight-range to turn the background of those lines some color. > > If it is a stack, that's harder, as you'd want to include some > graphical manifestation of the ordering. (But I think the lack of > order is better.) > > On Fri, Feb 3, 2012 at 11:06 AM, Stephen Chang <stch...@ccs.neu.edu> wrote: >>> - it would be good if there was some graphical representation of the >>> current bookmarks state. >> >> Any ideas on what the graphical representation should look like? >> Should it be a popup window? Or a side bar? >> >> >>> >>> - did you consider just having an (unordered) list of bookmarks? Then, >>> adding a book mark would be a keystroke that'd be separate from >>> jumping around, so you'd have to set them yourself, but you could >>> iterate around in the set bookmarks, instead of having to keep track >>> of which things are on top of the stack. >>> >>> I think the first one probably has to be fixed before we a release >>> could contain this feature. (The second one seems important, but not >>> as much as the first.) >>> >>> Robby >>> >>> On Fri, Feb 3, 2012 at 1:06 AM, Stephen Chang <stch...@ccs.neu.edu> wrote: >>>> When using Dr Racket, I use the right-click "Jump to definition of" a >>>> lot but I frequently find that I also want an easy way to get back to >>>> the code I was previously looking at. Does anyone else think this >>>> would be a useful feature to have? I've implemented something that >>>> adds this functionality. >>>> >>>> If anyone wants to try it out, I've included both modified source >>>> files (from drracket/private) and a patch. >>>> >>>> With the code I added, a "bookmark" automatically gets saved when >>>> jumping to a definition from the right-click menu and when choosing a >>>> definition from the "(define ...)" menu. Multiple bookmarks accumulate >>>> on a stack. You can also add your own bookmarks with the right click >>>> menu. >>>> >>>> To go back to the most recent bookmark, either use the right-click >>>> menu, or press C-x r (is this an appropriate key binding? I chose it >>>> because emacs similarly uses C-x r to do bookmark-related stuff). >>>> >>>> Since I'm not very familiar with drracket code, I'm not sure I put >>>> stuff in the right place. Would anyone mind reviewing my code? It's >>>> only a few lines. >>>> >>>> Also, would something like this be better as a plugin in the future? >>>> >>>> _________________________ >>>> Racket Developers list: >>>> http://lists.racket-lang.org/dev >>>> > > _________________________ > Racket Developers list: > http://lists.racket-lang.org/dev _________________________ Racket Developers list: http://lists.racket-lang.org/dev