Hi,

Contributions to the project, even minor ones, are always welcome. I've
cherry-picked some of your comments below that you could work on patches
for, some of the other suggestions are a bit more contraversial and could
be considered later.


On Fri, Feb 3, 2017 at 12:37 AM, Zsombor <[email protected]> wrote:

>
> * There are lot's of places, where the fields could be marked as private
> and/or final, but it's omitted, why ? Is it a lack of time, or interest ?
>

No reason, please feel free to submit a patch.

* Lot's of places, where there are empty blocks, even empty methods - or
> exception "handling" as 'e.printStackTrace()'
>

Yes agreed this needs to be improved.


> * And smaller issues, like initializing fields unnecessarily, or calling
> x.equalsIgnoreCase("something") instead of "something".equalsIgnoreCase(x)
>
>
Again, please submit a patch for this.

Colm.


> What do you think, is it worth working on these?
>
> Best regards,
>  Zsombor
>



-- 
Colm O hEigeartaigh

Talend Community Coder
http://coders.talend.com

Reply via email to