----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56320/#review164483 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Feb. 7, 2017, 1:48 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56320/ > ----------------------------------------------------------- > > (Updated Feb. 7, 2017, 1:48 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and Ramesh > Mani. > > > Bugs: RANGER-1353 > https://issues.apache.org/jira/browse/RANGER-1353 > > > Repository: ranger > > > Description > ------- > > when the value of NameRules is not configured in Kerberized Environment, > I start ranger-admin,it will cause java.lang.NullPointerException > the error message is as follows: > java.lang.NullPointerException > at > org.apache.hadoop.security.authentication.util.KerberosName.getShortName(KerberosName.java:383) > at org.apache.hadoop.security.User.<init>(User.java:48) > at > org.apache.hadoop.security.SecureClientLogin.loginUserFromKeytab(SecureClientLogin.java:65) > at > org.apache.ranger.server.tomcat.EmbeddedServer.start(EmbeddedServer.java:232) > at > org.apache.ranger.server.tomcat.EmbeddedServer.main(EmbeddedServer.java:72) > > so we should add the default value in Java method EmbeddedServer.start(): > > String nameRules = getConfig(ADMIN_NAME_RULES); > if (getConfig(AUTHENTICATION_TYPE) != null > && > getConfig(AUTHENTICATION_TYPE).trim().equalsIgnoreCase(AUTH_TYPE_KERBEROS) > && SecureClientLogin.isKerberosCredentialExists(principal,keytab)) { > ... > } > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 54c190d > > Diff: https://reviews.apache.org/r/56320/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
