----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55669/#review164609 -----------------------------------------------------------
Looks like there are recent changes to security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java because of which I am not able to apply the patch. Once I fixed that, I compiled and tried the changes in one of my test cluster with usersync module configuration changes. I was able to test the changes successfully with usersync. Also, I went through the changes and they look fine. Please sync with latest changes and update the patch. - Sailaja Polavarapu On Feb. 1, 2017, 5:47 p.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55669/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2017, 5:47 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1318 > https://issues.apache.org/jira/browse/RANGER-1318 > > > Repository: ranger > > > Description > ------- > > Currently, duplicate code appears in several places to parse XML. Instead it > should all be consolidated in a single place. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/XMLUtils.java > PRE-CREATION > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/EmbeddedServer.java > 54c190d > security-admin/src/main/java/org/apache/ranger/common/RangerProperties.java > cb8b825 > > security-admin/src/main/java/org/apache/ranger/common/XMLPropertiesUtil.java > 8fd6196 > > ugsync/src/main/java/org/apache/ranger/unixusersync/config/UserGroupSyncConfig.java > 25c0824 > > unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java > 178eb53 > > unixauthservice/src/main/java/org/apache/ranger/authentication/UnixAuthenticationService.java > 4b56936 > > Diff: https://reviews.apache.org/r/55669/diff/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
