> On Feb. 19, 2017, 10:34 p.m., Selvamohan Neethiraj wrote: > > Can you please provide little more details on how the manual testing was > > done. This would be helpful for reviewer ....
With the fix, the user sync is run ok without the exception after the removal of the "short user name" from the "or" logic for the group search, leaving only the full DN as the user name for the group search. Before the fix, the same search caused the InvalidNameException thrown from the LDAP server. As stated in the Jira, apparently the problem is only with some LDAP servers. Using the Apache LDAP server in the Ranger automated user sync test, TestLdapUserGroup, the failure can't be reproduced. - Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56829/#review166044 ----------------------------------------------------------- On Feb. 19, 2017, 10:30 p.m., Yan Zhou wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56829/ > ----------------------------------------------------------- > > (Updated Feb. 19, 2017, 10:30 p.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > Some LDAP servers throw exception on group search on posix user names that > are not full DNs. > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapUserGroupBuilder.java > 8cf6816 > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/PolicyMgrUserGroupBuilder.java > 070a39b > > Diff: https://reviews.apache.org/r/56829/diff/ > > > Testing > ------- > > Manual > > > Thanks, > > Yan Zhou > >
