-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56864/
-----------------------------------------------------------

Review request for ranger, Don Bosco Durai and Colm O hEigeartaigh.


Bugs: RANGER-1398
    https://issues.apache.org/jira/browse/RANGER-1398


Repository: ranger


Description
-------

I checked the codes and found we will get 'minimumGroupId' from 
ranger-ugsync-site.xml, but I can't find this parameter in this file after 
execute the shell script.
The reason why I set the value for 'ranger.usersync.unix.minGroupId' as 500:
The value must be non-negative. The default is to use the smallest ID value 
greater than 500 and greater than every other group. Values between 0 and 499 
are typically reserved for system accounts.


Diffs
-----

  unixauthservice/conf.dist/ranger-ugsync-default.xml 5ed5b89 
  unixauthservice/scripts/install.properties 13ae1e5 
  unixauthservice/scripts/templates/installprop2xml.properties 1a9bf36 
  unixauthservice/scripts/templates/ranger-ugsync-template.xml 0025dc8 

Diff: https://reviews.apache.org/r/56864/diff/


Testing
-------

$ git apply --stat 
0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
 .../conf.dist/ranger-ugsync-default.xml            |    4 ++++
 unixauthservice/scripts/install.properties         |    6 ++++++
 .../scripts/templates/installprop2xml.properties   |    1 +
 .../scripts/templates/ranger-ugsync-template.xml   |    4 ++++
 4 files changed, 15 insertions(+)
$ git am --signoff < 
0001-RANGER-1398-Missing-the-settings-for-ranger.usersync.patch
Applying: RANGER-1398:Missing the settings for ranger.usersync.unix.minGroupId 
in ranger usersync module


Thanks,

Qiang Zhang

Reply via email to