----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56862/#review166132 -----------------------------------------------------------
getTblList and getClmList could be made private methods as well IMO - Colm O hEigeartaigh On Feb. 21, 2017, 3:42 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56862/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 3:42 a.m.) > > > Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, and > Selvamohan Neethiraj. > > > Bugs: RANGER-1397 > https://issues.apache.org/jira/browse/RANGER-1397 > > > Repository: ranger > > > Description > ------- > > public List<String> getTblList(String tableNameMatching, List<String> dbList, > List<String> tblList) throws HadoopException { > > if(LOG.isDebugEnabled()) { > LOG.debug("==> HiveClient getTableList() tableNameMatching : " > + tableNameMatching + " ExcludedbList :" + dbList + "ExcludeTableList :" + > tblList); > } > ... > if(LOG.isDebugEnabled()) { > LOG.debug("<== HiveClient getTableList() " + ret); > } > > return ret; > } > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/services/hive/client/HiveClient.java > ec61458 > > Diff: https://reviews.apache.org/r/56862/diff/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >
