----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57585/#review168891 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On March 14, 2017, 4:03 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57585/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 4:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, and Velmurugan Periasamy. > > > Bugs: RANGER-1451 > https://issues.apache.org/jira/browse/RANGER-1451 > > > Repository: ranger > > > Description > ------- > > In hadoop security authentication, there are some error message doesn't match > the logic. > if (fsDefaultName.isEmpty()) { > throw new IllegalArgumentException("Value for neither fs.default.name > is specified"); > } > It should be not specified here. > > > Diffs > ----- > > > hdfs-agent/src/main/java/org/apache/ranger/services/hdfs/client/HdfsClient.java > c5331a3 > > > Diff: https://reviews.apache.org/r/57585/diff/1/ > > > Testing > ------- > > > Thanks, > > Qiang Zhang > >