-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57987/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-1478
https://issues.apache.org/jira/browse/RANGER-1478
Repository: ranger
Description
-------
RangerPolicyEngineOptions has a lot of public fields, which is written from
various places from the code base, which should be avoided. That object is
configured from RangerConfiguration, but in the middle of the plugin
initialization code, which makes this a bit more complex, than it should be.
Suggestions:
RangerConfiguration should be treated as an object, not a static facade for
a couple of config values
RangerPolicyEngineOptions should get his configuration from directly the
RangerConfiguration, in an explicit, encapsulated way.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineCache.java
5376b5205cb7b0b0a6f7b827198bbee055191f0f
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineOptions.java
a9027bca75b66836c87fc0508f99ef9787d99512
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
acf8d1545536d84b0f7d20b971655fe20c67cfa6
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java
617631949244993e46f5b0ab2168acc6ed0bf634
Diff: https://reviews.apache.org/r/57987/diff/1/
Testing
-------
Thanks,
Zsombor Gegesy
