-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56490/
-----------------------------------------------------------
(Updated 四月 7, 2017, 10:10 a.m.)
Review request for ranger, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad,
Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, and Velmurugan Periasamy.
Bugs: RANGER-1369
https://issues.apache.org/jira/browse/RANGER-1369
Repository: ranger
Description (updated)
-------
#Description:
There are some logic defects in the following
script(/security-admin/contrib/solr_for_audit_setup/setup.sh):
sudo chown -R $SOLR_USER:$SOLR_USER $SOLR_INSTALL_FOLDER
set_ownership $SOLR_USER $SOLR_USER $SOLR_INSTALL_FOLDER
It will cause invalid group error if the group does not exist.
And these logics do not support the case where the user name is different with
the user group.
We should use SOLR_GROUP to resolve these logic defects. The new code is as
following:
sudo chown -R $SOLR_USER:$SOLR_GROUP $SOLR_INSTALL_FOLDER
set_ownership $SOLR_USER $SOLR_GROUP $SOLR_INSTALL_FOLDER
And set a value for SOLR_GROUP alone.
Diffs
-----
security-admin/contrib/solr_for_audit_setup/install.properties fc9955d
security-admin/contrib/solr_for_audit_setup/setup.sh 41a51d8
Diff: https://reviews.apache.org/r/56490/diff/2/
Testing
-------
#Test Result:
1.Configure install.properties of solr_for_audit_setup:
SOLR_USER=solr
SOLR_GROUP=hadoop
SOLR_INSTALL=false
SOLR_DEPLOYMENT=standalone
2.Execute the script setup.sh of solr_for_audit_setup as root success
3.Start Solr and Ranger-Admin(use slor for audit) success
Thanks,
Qiang Zhang
