> On April 25, 2017, 9:56 a.m., Colm O hEigeartaigh wrote: > > I'm a bit unsure about changing the name of the log file. Could we just not > > log the user + host information inside the file? > > pengjianhua wrote: > The user can not directly determine following information from current > log file when they collect log files from the large data platform to log > analysis center for analysis log. > 1. Who is running the Ranger. > 2. In which machine running the Ranger. > Of course, they can also get above information using other ways, Such as > by analyzing the owner of the log and so on when collecting log files. This > will bring more work to users who use ranger and reduce collect system > performance. > > So The new method should be more reasonable than the current method. do > you think?
I'd like to get the feedback of some of the other developers before merging this fix. - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58660/#review172904 ----------------------------------------------------------- On April 24, 2017, 9:01 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58660/ > ----------------------------------------------------------- > > (Updated April 24, 2017, 9:01 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1540 > https://issues.apache.org/jira/browse/RANGER-1540 > > > Repository: ranger > > > Description > ------- > > Log is very important for big data platform. The main purpose of log analysis > is that we need to know who is running the service, in which machine running > service, which service out of the problem. The ranger security admin should > support the feature. > Implement logic: > 1. Modify the value of log4j.appender.xa_log_appender.file from $ > {logdir}/ranger_admin.log to ${logdir} > > /ranger-$ > {user}rangeradmin${hostname}.log in > /security-admin/src/main/webapp/WEB-INF/log4j.properties file. > 2. Pass ${user} > > and $ > {hostname} > > as parameters to org.apache.ranger.server.tomcat.EmbeddedServer. > 3. User obtains the user and hostname information by parsing the log file > name. > > > Diffs > ----- > > embeddedwebserver/scripts/ranger-admin-services.sh f2d2bf5 > security-admin/src/main/webapp/WEB-INF/log4j.properties 211de86 > > > Diff: https://reviews.apache.org/r/58660/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
