> On May 9, 2017, 3:27 p.m., Colm O hEigeartaigh wrote: > > There are some whitespace issues when I look at the patch in vi. The end > > "fi" is not aligned with "then". I also think the "do" should be underneath > > the "for" as per the other examples in the file. > > > > Have you installed a plugin with this change to make sure it works > > correctly?
I installed the hbase and hive plugin to test the function. The test result shown that the function worked correctly. I had rebuilt the patch and verify it using git apply --check and git am --signoff command before updated the patch. - pengjianhua ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59079/#review174321 ----------------------------------------------------------- On May 10, 2017, 8:03 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59079/ > ----------------------------------------------------------- > > (Updated May 10, 2017, 8:03 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1564 > https://issues.apache.org/jira/browse/RANGER-1564 > > > Repository: ranger > > > Description > ------- > > The SQL_CONNECTOR_JAR properity had been deleted in RANGER-1387. The invalid > code should also be deleted to keep the code consistent in the > /agents-common/scripts/enable-agent.sh. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh 14e9577 > > > Diff: https://reviews.apache.org/r/59079/diff/2/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
