----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57868/#review175099 -----------------------------------------------------------
Please submit a patch for "master" only. Also the latest patch still has the "Permissions Details" change in it. When you are submitting a patch, please use " git format-patch -n HEAD~" as per: https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=55151244 - Colm O hEigeartaigh On May 16, 2017, 1:47 p.m., Haihui Xu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57868/ > ----------------------------------------------------------- > > (Updated May 16, 2017, 1:47 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1411 > https://issues.apache.org/jira/browse/RANGER-1411 > > > Repository: ranger > > > Description > ------- > > Navigate to Ranger Web UI's Settings Permissions tab, the permissions table > header is Permissions,Groups,Users,Action. But the first column in the table > is modules(Resource Based Policies,Users/Groups,Audits,Reports...). So the > table header should be Modules,Groups,Users,Action. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 7a4b82c > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > 92c07c7 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 909d2fc > > > Diff: https://reviews.apache.org/r/57868/diff/1/ > > > Testing > ------- > > Page Display, test ok. > > > File Attachments > ---------------- > > RANGER-1411.patch > > https://reviews.apache.org/media/uploaded/files/2017/05/16/5ef6eb5a-42c7-4aa7-8c54-7deace5ce158__RANGER-1411.patch > > > Thanks, > > Haihui Xu > >
