> On May 17, 2017, 11:12 a.m., Colm O hEigeartaigh wrote: > > Why is the iteration count now "17"? > > bhavik patel wrote: > For previous version this iteration count was 17 so to support backwards > compatibility we have kept this count as 17, once the upgrade is successful > the user can change the value in xml file. > For fresh install whatever the user want they can configure accordingly. > > Colm O hEigeartaigh wrote: > OK thanks. For a new major release like 1.0.0 though, would it not be > better to default to "1000" and any user who is upgrading can change it to > "17"? > > bhavik patel wrote: > Yes, user can do that but if we set default to "1000" then test > connection & resource-lookup will not work for old repo's those created in > minor version; so we have set it to "17".
Yes understood, let me rephrase a bit though: "is having to change a config value for backwards compatibility in a new major release worse than forever having an insecure default value of 17 for new installs"? From a security POV we should always aim to be "secure by default". - Colm ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59335/#review175228 ----------------------------------------------------------- On May 17, 2017, 11:05 a.m., bhavik patel wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59335/ > ----------------------------------------------------------- > > (Updated May 17, 2017, 11:05 a.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, > and Velmurugan Periasamy. > > > Bugs: RANGER-1583 > https://issues.apache.org/jira/browse/RANGER-1583 > > > Repository: ranger > > > Description > ------- > > After upgrade from ranger-0.6 to ranger-0.7 all test connections are failing > for plugins. > Below error is shown in xa_portal.log: > ERROR org.apache.ranger.plugin.util.PasswordUtils (PasswordUtils.java:129) - > Unable to decrypt password due to error > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java > 3759b8d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > a44aa46 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 4f5f1d3 > > > Diff: https://reviews.apache.org/r/59335/diff/1/ > > > Testing > ------- > > 1. After upgrade from ranger-0.6 to ranger-0.7 verified plugins > test-connections & resource-lookup. > > > Thanks, > > bhavik patel > >