----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59296/#review175348 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java Line 253 (original), 274 (patched) <https://reviews.apache.org/r/59296/#comment248800> Wouldn't it be enough to parse the given value using date-formats in array RangerScriptExecutionContext.dateFormatStrings - as long as this array is sorted by descending order of the format string length? - Madhan Neethiraj On May 18, 2017, 1:35 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59296/ > ----------------------------------------------------------- > > (Updated May 18, 2017, 1:35 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1581 > https://issues.apache.org/jira/browse/RANGER-1581 > > > Repository: ranger > > > Description > ------- > > Ranger plugins interpret tag attributes of type 'date' using an internal > Ranger date-format string. Now, in addition to the internal Ranger > date-format string ("yyyy/MM/dd"), plugins also support a comma-separated > list of data-format strings, based on the value of the plugin configuration > parameter "ranger.plugin.tag.attr.additional.date.formats". A special value > string "ATLAS_DATE_FORMAT" is supported to refer to default date-format used > by Atlas. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/conditionevaluator/RangerScriptExecutionContext.java > c46f527 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > e556f16 > > agents-common/src/test/resources/policyengine/test_policyengine_tag_hive.json > 34ccaac > > > Diff: https://reviews.apache.org/r/59296/diff/4/ > > > Testing > ------- > > Developed a unit test for testing specification and use of > "ranger.plugin.tag.attr.additional.date.formats" configuration variable. > > > Thanks, > > Abhay Kulkarni > >
