> On June 13, 2017, 8:49 a.m., Colm O hEigeartaigh wrote: > > Please put curly brackets around the two one-line if statements: > > if(LOG.isDebugEnabled())
Thanks, updated with the suggested changes. - Ankita ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60034/#review177715 ----------------------------------------------------------- On June 13, 2017, 9:55 a.m., Ankita Sinha wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60034/ > ----------------------------------------------------------- > > (Updated June 13, 2017, 9:55 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1582 > https://issues.apache.org/jira/browse/RANGER-1582 > > > Repository: ranger > > > Description > ------- > > Actual : > Currently Knox SSO is just supported from Ranger UI through web browser. > > Expected : > Support KNOX SSO Token based authentication on Ranger REST API calls. > > > Diffs > ----- > > > security-admin/src/main/java/org/apache/ranger/security/web/filter/RangerSSOAuthenticationFilter.java > ffb60b9 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > f0ccae1 > > > Diff: https://reviews.apache.org/r/60034/diff/2/ > > > Testing > ------- > > 1. Checked Knox SSO for REST API Calls > 2. Knox SSO working as expected from Ranger UI > 3. Tested in secure as well as simple environment. > > > Thanks, > > Ankita Sinha > >
