----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59942/#review178453 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On 六月 9, 2017, 9:42 a.m., Colm O hEigeartaigh wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/59942/ > ----------------------------------------------------------- > > (Updated 六月 9, 2017, 9:42 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1635 > https://issues.apache.org/jira/browse/RANGER-1635 > > > Repository: ranger > > > Description > ------- > > The credential builder tests write keystores files to the user's home > directory (and don't delete them afterwards). Instead they should write to > the target directory. Also I removed some duplicate assertions and cleaned > the testcode up a bit. > > > Diffs > ----- > > > credentialbuilder/src/test/java/org/apache/ranger/credentialapi/TestCredentialReader.java > 4c2e86ef > > credentialbuilder/src/test/java/org/apache/ranger/credentialapi/Testbuildks.java > ce93b65f > > > Diff: https://reviews.apache.org/r/59942/diff/1/ > > > Testing > ------- > > > Thanks, > > Colm O hEigeartaigh > >
