----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60043/ -----------------------------------------------------------
(Updated June 22, 2017, 1:50 p.m.) Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan Periasamy. Changes ------- Added unit test Bugs: RANGER-1639 https://issues.apache.org/jira/browse/RANGER-1639 Repository: ranger Description ------- Actual : Ranger KMS does not validate key name before importing into DB. So the imported key can have special characters in Key name. Expected : Ranger KMS should validate key name before importing into DB. Diffs (updated) ----- kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStore.java 09b46bc kms/src/test/java/org/apache/hadoop/crypto/key/kms/TestRangerKeyStore.java PRE-CREATION Diff: https://reviews.apache.org/r/60043/diff/3/ Changes: https://reviews.apache.org/r/60043/diff/2-3/ Testing ------- Below steps were followed to test this scenario 1. Installed Hadoop KMS 2. Created encryption keys with combination of special characters, alphabets and numbers 3. Installed Ranger KMS 4. imported hadoop key jceks to Ranger KMS (Validation was successful) Thanks, Ankita Sinha