> On 七月 24, 2017, 4:40 p.m., Colm O hEigeartaigh wrote:
> > Why is the noggit dependency introduced in agents-audit? Also the protobuf
> > version in the root pom that isn't used? You need to make the changes to
> > src/main/assembly/kms.xml as I explained above.
>
> Colm O hEigeartaigh wrote:
> Actually all of the files that reference noggit in src/main/assembly
> should be changed along these lines:
>
>
> <include>org.noggit:noggit:jar:${noggit.version}</include>
>
> with
>
> <include>org.noggit:noggit</include>
>
> That includes the noggit jar in the plugins without having to add a
> dependency in the poms. We should also do the same for:
>
> 'com.google.protobuf:protobuf-java:jar:${protobuf-java.version}
Ok. I rebuilt the patch after carefully checked and verified it. Thanks.
- pengjianhua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/60997/#review181226
-----------------------------------------------------------
On 七月 25, 2017, 9:32 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/60997/
> -----------------------------------------------------------
>
> (Updated 七月 25, 2017, 9:32 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan
> Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1698
> https://issues.apache.org/jira/browse/RANGER-1698
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Plugin writed audit log to solr failure because of the lack of noggit-0.6.jar
> in plugin lib path.
> The following issue removed the related dependency:
> RANGER-1587 - Cleanup Ranger KMS service dependencies.
>
>
> Diffs
> -----
>
> pom.xml 3fcc4aa
>
>
> Diff: https://reviews.apache.org/r/60997/diff/3/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
