----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61624/ -----------------------------------------------------------
Review request for ranger. Bugs: RANGER-1733 https://issues.apache.org/jira/browse/RANGER-1733 Repository: ranger Description ------- The same RangerDaoManager is injected multiple times, unnecessarily. One fields is more than enough. Diffs ----- security-admin/src/main/java/org/apache/ranger/service/AbstractBaseResourceService.java 3c2f263 security-admin/src/main/java/org/apache/ranger/service/AuthSessionService.java 249a695 security-admin/src/main/java/org/apache/ranger/service/UserService.java 91fb38b security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java 8604bed security-admin/src/main/java/org/apache/ranger/service/XAssetService.java 3aab900 security-admin/src/main/java/org/apache/ranger/service/XAuditMapService.java e090391 security-admin/src/main/java/org/apache/ranger/service/XGroupPermissionService.java 6329e6b security-admin/src/main/java/org/apache/ranger/service/XGroupService.java 1253eec security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 52f8b1a security-admin/src/main/java/org/apache/ranger/service/XModuleDefService.java f66cdfe security-admin/src/main/java/org/apache/ranger/service/XPermMapService.java 1a59975 security-admin/src/main/java/org/apache/ranger/service/XResourceService.java 004ded4 security-admin/src/main/java/org/apache/ranger/service/XTrxLogService.java 7618981 security-admin/src/main/java/org/apache/ranger/service/XUserPermissionService.java 76b7400 security-admin/src/main/java/org/apache/ranger/service/XUserService.java 294223b Diff: https://reviews.apache.org/r/61624/diff/1/ Testing ------- Tested locally. https://travis-ci.org/gzsombor/ranger/builds/264508518 Thanks, Zsombor Gegesy