[
https://issues.apache.org/jira/browse/RANGER-1725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16141231#comment-16141231
]
Madhan Neethiraj commented on RANGER-1725:
------------------------------------------
[~peng.jianhua] - I wanted to understand the use-case that prompted this fix.
Only behavior difference seen will be for config values such as ",", ",," -
which I thought would not be used in a typical deployment, unless someone
wanted to have no restrictions on the service-defs to load. Your patch
essentially would cause such config value to not load any service-def at all.
Unless a specific use-case is impacted in a real deployment, I would suggest to
not change the implementation - to avoid unnecessary testing overheads.
> It is incorrect to judge whether you need to create a RangerServiceDef object
> for a given service
> -------------------------------------------------------------------------------------------------
>
> Key: RANGER-1725
> URL: https://issues.apache.org/jira/browse/RANGER-1725
> Project: Ranger
> Issue Type: Bug
> Components: Ranger
> Reporter: peng.jianhua
> Assignee: peng.jianhua
> Labels: patch
> Fix For: 1.0.0
>
> Attachments:
> 0001-RANGER-1725-It-is-incorrect-to-judge-whether-you-nee.patch
>
>
> It is incorrect to judge whether you need to create a RangerServiceDef object
> for a given service.
> The current judgment condition is in the
> org.apache.ranger.plugin.store.EmbeddedServiceDefsUtil#getOrCreateServiceDef,
> as follows
> {code:java}
> boolean createServiceDef = (CollectionUtils.isEmpty(supportedServiceDefs) ||
> supportedServiceDefs.contains(serviceDefName));
> {code}
> It means When the supportedServiceDefs is empty, the RangerServiceDef object
> for the specified service will be created, but I think this judge is
> incorrect.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
