FW: New Defects reported by Coverity Scan for Apache Ranger

[Don Bosco Durai]

Please review and fix if required.

Thanks

Bosco


On 9/14/17, 2:19 AM, "scan-ad...@coverity.com" <scan-ad...@coverity.com> wrote:

    
    Hi,
    
    Please find the latest report on new defect(s) introduced to Apache Ranger 
found with Coverity Scan.
    
    1 new defect(s) introduced to Apache Ranger found with Coverity Scan.
    3 defect(s), reported by Coverity Scan earlier, were marked fixed in the 
recent build analyzed by Coverity Scan.
    
    New defect(s) Reported-by: Coverity Scan
    Showing 1 of 1 defect(s)
    
    
    ** CID 167104:  FindBugs: Bad practice  (FB.DM_EXIT)
    
/security-admin/src/main/java/org/apache/ranger/patch/PatchForNifiResourceUpdateExclude_J10008.java:
 138 in 
org.apache.ranger.patch.PatchForNifiResourceUpdateExclude_J10008.updateNifiServiceDef()()
    
    
    
________________________________________________________________________________________________________
    *** CID 167104:  FindBugs: Bad practice  (FB.DM_EXIT)
    
/security-admin/src/main/java/org/apache/ranger/patch/PatchForNifiResourceUpdateExclude_J10008.java:
 138 in 
org.apache.ranger.patch.PatchForNifiResourceUpdateExclude_J10008.updateNifiServiceDef()()
    132                                     RangerServiceDefValidator validator 
= validatorFactory.getServiceDefValidator(svcStore);
    133                                     
validator.validate(dbNifiServiceDef, Action.UPDATE);
    134                                     ret = 
svcStore.updateServiceDef(dbNifiServiceDef);
    135                             }
    136                             if (ret == null) {
    137                                     logger.error("Error while updating 
" + EmbeddedServiceDefsUtil.EMBEDDED_SERVICEDEF_NIFI_NAME+ "service-def");
    >>>     CID 167104:  FindBugs: Bad practice  (FB.DM_EXIT)
    >>>     
org.apache.ranger.patch.PatchForNifiResourceUpdateExclude_J10008.updateNifiServiceDef()
 invokes System.exit(...), which shuts down the entire virtual machine.
    138                                     System.exit(1);
    139                             }
    140                     } catch (Exception e) {
    141                             logger.error("Error while updating " + 
EmbeddedServiceDefsUtil.EMBEDDED_SERVICEDEF_NIFI_NAME + "service-def", e);
    142                     }
    143             }
    144     
    
    
    
________________________________________________________________________________________________________
    To view the defects in Coverity Scan visit, 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRZSbhom32dlDl11LWEm9nX11zsOWMf5dv3Q9Mogo-2FGua3FsLRTFft2V-2FOFC9o0P2e0-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZs2qU5Gq3l8Fcz8-2B5uxZQ-2BkPW6pytVd-2Fe91b3vqcCqeRCKveZY3EnnJ6XPgF6gfKZfhxfUyMFFokJFkYvU4na3gVO9Fc1Q6r2NAtI5lSSCeZ7y4Dj29CaMGYkqe39A2IH0xSKo0A30WBExulPDkMwSXyRq9GGcLH3kIs7pn-2BdCzmg-3D-3D
    
    To manage Coverity Scan email notifications for "bo...@apache.org", click 
https://u2389337.ct.sendgrid.net/wf/click?upn=08onrYu34A-2BWcWUl-2F-2BfV0V05UPxvVjWch-2Bd2MGckcRbVDbis712qZDP-2FA8y06Nq4HK0JLY-2BbZ-2FD0yvjg-2BbWSwquqqdEYtbR9nIDW-2BM81kI8TiABM2LsH3tiPfMWf-2FvOsjZSWngS5IRVC-2FH5Pl4zyaK1OE6Dh-2BhR6pXASEFJKZLM-3D_d04ZgyDzSjlwpjXIuOFYDNE6R93Lal83MDClQK32PZs2qU5Gq3l8Fcz8-2B5uxZQ-2Bk3yXYhMZupY4qVnjecJHFUcyds3n-2F3tqUt6xzkY2-2BftBjVlKjiIpZMVo4mDjxMYbzlFjQ3iQzDxPl5TtAD-2FZv3Z-2FJd-2BTik1yUvDlledWoIvESVtyAPih2qi75ctpYajAok-2B1ZzEEALf5SgOAOcPkeVQ-3D-3D