----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62328/#review185544 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On Sept. 14, 2017, 12:33 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62328/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2017, 12:33 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Mehul Parikh, and > Velmurugan Periasamy. > > > Bugs: RANGER-1682 > https://issues.apache.org/jira/browse/RANGER-1682 > > > Repository: ranger > > > Description > ------- > > Steps to repro > 1)login to ranger UI. > 2) wait until the session is expired / delete the cookies from the browser > 3)Click on export button of any service > 4)The loader is shown indefinitely. > In the background, the below call fails with HTTP Status 419 > http://<hostname>:6080/service/plugins/policies/exportJson?serviceName=<servicename>&checkPoliciesExists=true > Expected: Should go to login page if session is expired. > > > Diffs > ----- > > security-admin/src/main/webapp/login.jsp 39fb327 > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js 56411b4 > security-admin/src/main/webapp/scripts/models/XABaseModel.js 6083210 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 1979847 > security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js > fb10562 > security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js 338fffb > security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js fbbee46 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js > aa4c332 > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > bb64984 > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyRO.js > 3011f1e > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > c551887 > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js aecaf95 > security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js > c2b78ab > security-admin/src/main/webapp/scripts/views/user/UserProfile.js cac80a8 > > > Diff: https://reviews.apache.org/r/62328/diff/1/ > > > Testing > ------- > > 1.UI able to redirect to login page clicking on export service button after > session timeout and also shows session timeout message in the alert box. > 2.Also most of modules are convered for the same scenario. > > > Thanks, > > Nitin Galave > >