----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62552/#review186175 -----------------------------------------------------------
agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java Line 473 (original), 473 (patched) <https://reviews.apache.org/r/62552/#comment262624> Bosco suggested that taking this type of action for all types of events (HDFS vs Kafka) may be too wide. What does everyone think about adding another config that's a csv (with potentially regex) of all the resource paths that should be considered under this type of aggregation? - Alejandro Fernandez On Sept. 25, 2017, 11:50 p.m., Alejandro Fernandez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62552/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2017, 11:50 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > and Ramesh Mani. > > > Bugs: RANGER-1780 > https://issues.apache.org/jira/browse/RANGER-1780 > > > Repository: ranger > > > Description > ------- > > AuditSummaryQueue already has logic to enable the summarization, but it > requires 2 events to have the exact same resource path (plus a couple of > other fields such as user, access type, access result, action, client ip, > session). > This Jira is to add a config called > xasecure.audit.provider.summary.aggregate.level so that if it is set to > "directory" then 2 events can still be aggregated if they are files in the > same directory. > If the config is not specified its default value will be "file" which > preserves the existing behavior. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuditEventBase.java > b5791467 > > agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java > 8d71851e > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > eff38249 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditSummaryQueue.java > 4c250336 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 0e124f1a > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > af4d9b5c > > > Diff: https://reviews.apache.org/r/62552/diff/1/ > > > Testing > ------- > > Verified on live cluster. > Unit Tests passed > > Once merged, will update the wiki > https://cwiki.apache.org/confluence/display/RANGER/Ranger+0.5+Audit+Configuration#Ranger0.5AuditConfiguration-Summarization > > > Thanks, > > Alejandro Fernandez > >
