> On 九月 25, 2017, 2:20 p.m., Colm O hEigeartaigh wrote: > > I would leave in "Master Key" to make it clearer, e.g. "The Master Key > > Password is empty or not a valid password"
You are right,Colm O hEigeartaigh .I'll fix it. Thanks. - wang ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62522/#review186121 ----------------------------------------------------------- On 九月 25, 2017, 5:47 a.m., wang yuan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62522/ > ----------------------------------------------------------- > > (Updated 九月 25, 2017, 5:47 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1804 > https://issues.apache.org/jira/browse/RANGER-1804 > > > Repository: ranger > > > Description > ------- > > The exception information is error when judge password for > RangerKeyStoreProvider class > I think it should throw the password is error instead of throw master key not > exists. > {code} > String password = conf.get(ENCRYPTION_KEY); > if(password == null || password.trim().equals("") || > password.trim().equals("_") || password.trim().equals("crypted")){ > throw new IOException("Master Key Jceks does not > exists"); > } > {code} > > > Diffs > ----- > > kms/src/main/java/org/apache/hadoop/crypto/key/RangerKeyStoreProvider.java > 267fcf08 > > > Diff: https://reviews.apache.org/r/62522/diff/2/ > > > Testing > ------- > > > Thanks, > > wang yuan > >
