----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62555/#review186330 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java Lines 589 (patched) <https://reviews.apache.org/r/62555/#comment262822> Small nitpick here, there are 2 spaces after "groupname =" - Alejandro Fernandez On Sept. 26, 2017, 8:35 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62555/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2017, 8:35 p.m.) > > > Review request for ranger, Ankita Sinha, Gautam Borad, Abhay Kulkarni, Madhan > Neethiraj, Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja > Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-1801 > https://issues.apache.org/jira/browse/RANGER-1801 > > > Repository: ranger > > > Description > ------- > > Added code to check if the groupname and userid entry is already existing in > ranger db before adding or updating the entry. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java 7450302 > security-admin/src/main/java/org/apache/ranger/db/XXGroupUserDao.java > 1a76d27 > > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java > d1901d9 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 68548a5 > > > Diff: https://reviews.apache.org/r/62555/diff/2/ > > > Testing > ------- > > 1. Performed some functional tests with delta sync and update group > memberships in AD. > 2. Verified all the existing unit tests are passing. > > > Thanks, > > Sailaja Polavarapu > >
