-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62714/
-----------------------------------------------------------

Review request for ranger, Gautam Borad, Mehul Parikh, Pradeep Agrawal, and 
Velmurugan Periasamy.


Bugs: RANGER-1819
    https://issues.apache.org/jira/browse/RANGER-1819


Repository: ranger


Description
-------

Trying to delete some of the group with special character from the ranger 
admin, but not able to delete.
This issue happens only if there is `&` in the groupname like groupspecial#$@&

Same issue present in case of users.


Solution : Replace currently API (i.e delete by name) call with delete by user 
id API.So we don't have to do extra handling for special charactes and it also 
includes best practices for REST API.


Diffs
-----

  security-admin/src/main/java/org/apache/ranger/rest/XUserREST.java 5a58346 
  security-admin/src/main/webapp/scripts/model_bases/VXGroupBase.js b86120b 
  security-admin/src/main/webapp/scripts/model_bases/VXUserBase.js c4a0d6c 
  security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js 65a1d18 


Diff: https://reviews.apache.org/r/62714/diff/1/


Testing
-------

Testing :

1. Verified CRUD for users and groups.
2. Verified delete for users and groups with/without special characters 
including `#`.


Thanks,

Nitin Galave

Reply via email to