----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62483/#review188190 -----------------------------------------------------------
Ship it! Ship It! - Alejandro Fernandez On Oct. 16, 2017, 6:41 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62483/ > ----------------------------------------------------------- > > (Updated Oct. 16, 2017, 6:41 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1795 > https://issues.apache.org/jira/browse/RANGER-1795 > > > Repository: ranger > > > Description > ------- > > If a service is renamed in the presence of tagged service-resources that > refer to the service (through service-id), then a major discrepancy is > introduced in security+governance database. Therefore, it is necessary to > fail service update under these circumstances. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > 89c3326 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > e433f08 > security-admin/src/main/java/org/apache/ranger/db/XXServiceResourceDao.java > 9859992 > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 54226d9 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIs.java d3c22d7 > security-admin/src/main/java/org/apache/ranger/rest/PublicAPIsv2.java > fa3c68e > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 76e5088 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml a212e59 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > c51aa2e > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > 75cbdbd > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIs.java > 4eaca03 > security-admin/src/test/java/org/apache/ranger/rest/TestPublicAPIsv2.java > d65a426 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 7c48d54 > > > Diff: https://reviews.apache.org/r/62483/diff/2/ > > > Testing > ------- > > Ran all unit tests successfully. Tested with local VM. > > > Thanks, > > Abhay Kulkarni > >
