----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63085/#review188527 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java Lines 155 (patched) <https://reviews.apache.org/r/63085/#comment265527> Please add JavaDoc to new classes & methods. - Alejandro Fernandez On Oct. 18, 2017, 1:03 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63085/ > ----------------------------------------------------------- > > (Updated Oct. 18, 2017, 1:03 a.m.) > > > Review request for ranger, Madhan Neethiraj and Ramesh Mani. > > > Bugs: RANGER-1843 > https://issues.apache.org/jira/browse/RANGER-1843 > > > Repository: ranger > > > Description > ------- > > Performance improvements in RANGER-1771, in finding the policies for a given > resource, should be made in tag-enricher as well - to optimize finding of > tags applicable for a given resource. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 5f0a422d > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 210eb3d5 > > > Diff: https://reviews.apache.org/r/63085/diff/3/ > > > Testing > ------- > > Passes all unit tests. Tested with perf-tool locally. > > > Thanks, > > Abhay Kulkarni > >