-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63209/#review188920
-----------------------------------------------------------



@Endre Zoltan Kovacs : Have you tested plugins test-connection? If someone 
upgrade from ranger-0.6 to ranger-0.7 or master after then check plugins 
test-connection should not break, can you please confirm that.

note: If you want to use stronger crypto algorithm than you can directly 
specify in ranger-admin-default-site.xml rather than changing default value in 
PasswordUtils.java

- bhavik patel


On Oct. 22, 2017, 3:46 p.m., Endre Zoltan Kovacs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63209/
> -----------------------------------------------------------
> 
> (Updated Oct. 22, 2017, 3:46 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Bugs: RANGER-1644
>     https://issues.apache.org/jira/browse/RANGER-1644
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> changing outdate hash&crypto algorigthms: MD5&DES => SHA512&AES128
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/PasswordUtils.java 
> 58cdd3531 
>   
> agents-common/src/test/java/org/apache/ranger/plugin/util/PasswordUtilsTest.java
>  4e135aaa7 
>   security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java 
> da650747d 
>   
> security-admin/src/main/java/org/apache/ranger/service/RangerServiceService.java
>  3dd761a2b 
>   security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml 
> 9dfc03df1 
>   security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java 
> 976fd0cb8 
> 
> 
> Diff: https://reviews.apache.org/r/63209/diff/1/
> 
> 
> Testing
> -------
> 
> PasswordUtilsTest: added new unit test and updated previous ones
> Added service update test: on service update new service password will be 
> encrypted with the new algorithm
> 
> 
> Thanks,
> 
> Endre Zoltan Kovacs
> 
>

Reply via email to