----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63225/#review188998 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java Lines 588 (patched) <https://reviews.apache.org/r/63225/#comment265929> Nitpick - mixing of spaces and tabs makes this harder to read. agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java Lines 601 (patched) <https://reviews.apache.org/r/63225/#comment265930> Add some JavaDoc for this function - Alejandro Fernandez On Oct. 23, 2017, 9:45 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63225/ > ----------------------------------------------------------- > > (Updated Oct. 23, 2017, 9:45 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1781 > https://issues.apache.org/jira/browse/RANGER-1781 > > > Repository: ranger > > > Description > ------- > > This patch adds two service-def validations (a. for detecting cycles in > resource-def graph, and b. to ensure increasing level values in resource-def > hierarchies). > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > d0f015d > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefHelper.java > 7a719ab > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > 3f2cc2a > > agents-common/src/main/java/org/apache/ranger/plugin/policyresourcematcher/RangerDefaultPolicyResourceMatcher.java > e8d85c5 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerObjectFactory.java > 1a48151 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefHelper.java > 274028e > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > ca055ff > > agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_for_hdfs_policy.json > b779090 > > agents-common/src/test/resources/resourcematcher/test_defaultpolicyresourcematcher_for_resource_specific_policy.json > 6b774f8 > > > Diff: https://reviews.apache.org/r/63225/diff/1/ > > > Testing > ------- > > Developed unit tests for additional validations. > Ran all unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
