----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63284/#review189143 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On Oct. 25, 2017, 2:58 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63284/ > ----------------------------------------------------------- > > (Updated Oct. 25, 2017, 2:58 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1857 > https://issues.apache.org/jira/browse/RANGER-1857 > > > Repository: ranger > > > Description > ------- > > The value of RANGER_KMS_HOME logic is not correct in dba_script.py and > db_setup.py, Like db_setup.py in admin, we should optimize them. > The value of RANGER_KMS_HOME logic in dba_script.py is as following: > > if is_unix: > RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME") > if RANGER_KMS_HOME is None: > RANGER_KMS_HOME = os.getcwd() > elif os_name == "WINDOWS": > RANGER_KMS_HOME = os.getenv("RANGER_KMS_HOME") > > The value of RANGER_ADMIN_HOME logic in admin is as following: > > RANGER_ADMIN_HOME = os.getenv("RANGER_ADMIN_HOME") > if RANGER_ADMIN_HOME is None: > RANGER_ADMIN_HOME = os.getcwd() > > > Diffs > ----- > > kms/scripts/db_setup.py fb891983 > kms/scripts/dba_script.py c471f59c > > > Diff: https://reviews.apache.org/r/63284/diff/1/ > > > Testing > ------- > > > Thanks, > > pengjianhua > >
