----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63404/ -----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang. Bugs: RANGER-1863 https://issues.apache.org/jira/browse/RANGER-1863 Repository: ranger Description ------- Optimize the code and keep the code style consistent, remove the invalid code in the LoginModule class 1.Change from "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().toLowerCase()))));" to "serverCertValidation = (! (certValidationFlag != null && ("false".equalsIgnoreCase(certValidationFlag.trim().))));" 2.Change from "System.err.println("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");" to "log("Skipping RemoteLogin - [" + JAAS_ENABLED_PARAM + "] => [" + val + "]");" 3.remove invalid code /* Properties config = null; String val = (String) options.get(REMOTE_UNIX_AUTHENICATION_CONFIG_FILE_PARAM); log("Remote Unix Auth Configuration file [" + val + "]"); if (val != null) { XMLUtils.loadConfig(val, config); } if (config == null) { logError("Remote Unix Auth Configuration is being loaded from XML configuration - not Properties"); config = new Properties(); config.putAll(options); } */ Diffs ----- unixauthclient/src/main/java/org/apache/ranger/authentication/unix/jaas/RemoteUnixLoginModule.java ff296b4 Diff: https://reviews.apache.org/r/63404/diff/1/ Testing ------- tested it! Thanks, pengjianhua