----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63534/#review190018 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Nov. 3, 2017, 8:36 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63534/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2017, 8:36 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, and Velmurugan Periasamy. > > > Bugs: RANGER-1870 > https://issues.apache.org/jira/browse/RANGER-1870 > > > Repository: ranger > > > Description > ------- > > Modify the logic for buildUnixUserList and parseMembers method in > UnixUserGroupBuilder class > 1.In the buildUnixUserList method: > int len = tokens.length; > if (len = 3) groupId = tokens [3]; case ArrayIndexOutOfBoundsException. > Solution: change from "if (len < 3) {" to "if (len < 4) {" > > 2.Another similar error in the parseMembers method: > String[] tokens = line.split(":"); > if (tokens.length = 2) String groupId = tokens [2]; case > ArrayIndexOutOfBoundsException. > Solution:change from “if (tokens.length < 2)” to “if (tokens.length < 3)” > > > Diffs > ----- > > > ugsync/src/main/java/org/apache/ranger/unixusersync/process/UnixUserGroupBuilder.java > 045fe3f > > > Diff: https://reviews.apache.org/r/63534/diff/1/ > > > Testing > ------- > > tested it. > > > Thanks, > > Qiang Zhang > >
