----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63608/#review190284 -----------------------------------------------------------
Looks good to me. Just a few trivial changes: a) In getRandomLinkName and getRandomJobName there is no need to store the variable - just return it directly, e.g. return RandomStringUtils.randomAlphanumeric(10) + "-link"; b) Change new ArrayList<String>() to new ArrayList<>() - Colm O hEigeartaigh On Nov. 7, 2017, 6:56 a.m., Qiang Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63608/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2017, 6:56 a.m.) > > > Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, > Selvamohan Neethiraj, sam rome, Venkat Ranganathan, and Velmurugan Periasamy. > > > Bugs: RANGER-1830 > https://issues.apache.org/jira/browse/RANGER-1830 > > > Repository: ranger > > > Description > ------- > > Write unit test for RANGER-1810 sqoop plugin > > > Diffs > ----- > > plugin-sqoop/pom.xml 0c52e66 > > plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerAdminClientImpl.java > PRE-CREATION > > plugin-sqoop/src/test/java/org/apache/ranger/authorization/sqoop/authorizer/RangerSqoopAuthorizerTest.java > PRE-CREATION > plugin-sqoop/src/test/resources/log4j.properties PRE-CREATION > plugin-sqoop/src/test/resources/ranger-sqoop-security.xml PRE-CREATION > plugin-sqoop/src/test/resources/sqoop-policies.json PRE-CREATION > plugin-sqoop/src/test/resources/sqoop.properties PRE-CREATION > plugin-sqoop/src/test/resources/sqoop_bootstrap.properties PRE-CREATION > > > Diff: https://reviews.apache.org/r/63608/diff/1/ > > > Testing > ------- > > Tested > > > Thanks, > > Qiang Zhang > >
