-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63789/#review191312
-----------------------------------------------------------



The "String tagResourceName = null" definition could be moved into the if 
statement, e.g. String tagResourceName = 
serviceDef.getResources().get(0).getName();

- Colm O hEigeartaigh


On Nov. 17, 2017, 6:16 a.m., Qiang Zhang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63789/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2017, 6:16 a.m.)
> 
> 
> Review request for ranger, Ankita Sinha, Don Bosco Durai, Colm O 
> hEigeartaigh, Gautam Borad, Madhan Neethiraj, pengjianhua, Ramesh Mani, 
> Selvamohan Neethiraj, sam  rome, and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-1887
>     https://issues.apache.org/jira/browse/RANGER-1887
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> String tagResourceName = serviceDef.getResources().get(0).getName(); case 
> java.lang.IndexOutOfBoundsException in RangerServiceTag.class
> And print log error for RangerServiceStorm.class
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/services/tag/RangerServiceTag.java
>  ce6002b 
>   
> storm-agent/src/main/java/org/apache/ranger/services/storm/RangerServiceStorm.java
>  d4dbd7b 
> 
> 
> Diff: https://reviews.apache.org/r/63789/diff/3/
> 
> 
> Testing
> -------
> 
> Tested it
> 
> 
> Thanks,
> 
> Qiang Zhang
> 
>

Reply via email to