> On Nov. 11, 2017, 6:15 p.m., Kevin Risden wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditFileCacheProvider.java > > Line 62 (original), 62 (patched) > > <https://reviews.apache.org/r/63552/diff/3/?file=1880898#file1880898line62> > > > > Is this a bug regardless of the ORC change?
Yes this is a bug, it just logs a wrong message. so fixed it > On Nov. 11, 2017, 6:15 p.m., Kevin Risden wrote: > > agents-audit/src/main/java/org/apache/ranger/audit/utils/AuditWriter.java > > Lines 145 (patched) > > <https://reviews.apache.org/r/63552/diff/3/?file=1880900#file1880900line145> > > > > Will these folders have the correct permissions? yes, this is the existing functionality for creating the folders for audit logs. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63552/#review190782 ----------------------------------------------------------- On Nov. 17, 2017, 7:38 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63552/ > ----------------------------------------------------------- > > (Updated Nov. 17, 2017, 7:38 p.m.) > > > Review request for ranger, Don Bosco Durai and Madhan Neethiraj. > > > Repository: ranger > > > Description > ------- > > RANGER-1837:Enhance Ranger Audit to HDFS to support ORC file format > > > Diffs > ----- > > agents-audit/README.txt PRE-CREATION > agents-audit/pom.xml c8bd1d8 > > agents-audit/src/main/java/org/apache/ranger/audit/destination/HDFSAuditDestination.java > 66d8504 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditFileCacheProvider.java > 314b130 > > agents-audit/src/main/java/org/apache/ranger/audit/provider/AuditWriterFactory.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/provider/MiscUtil.java > eff3824 > > agents-audit/src/main/java/org/apache/ranger/audit/queue/AuditFileCacheProviderSpool.java > 41513ba > > agents-audit/src/main/java/org/apache/ranger/audit/utils/AbstractAuditWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/JSONWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCFileUtil.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/ORCWriter.java > PRE-CREATION > agents-audit/src/main/java/org/apache/ranger/audit/utils/Writer.java > PRE-CREATION > pom.xml 589cd6a > src/main/assembly/hbase-agent.xml 3ebc334 > src/main/assembly/hdfs-agent.xml 5279a9a > src/main/assembly/hive-agent.xml ca65c80 > src/main/assembly/knox-agent.xml 8357d49 > src/main/assembly/plugin-atlas.xml fd98811 > src/main/assembly/plugin-kafka.xml 95855d9 > src/main/assembly/plugin-kms.xml 6d15f2a > src/main/assembly/plugin-solr.xml de30bfb > src/main/assembly/plugin-sqoop.xml d2bd69a > src/main/assembly/plugin-yarn.xml c6a48e8 > src/main/assembly/storm-agent.xml 64224ec > > > Diff: https://reviews.apache.org/r/63552/diff/4/ > > > Testing > ------- > > Testing done in local > > > Thanks, > > Ramesh Mani > >
