> On Nov. 21, 2017, 7:06 p.m., Velmurugan Periasamy wrote: > > agents-audit/pom.xml > > Lines 48 (patched) > > <https://reviews.apache.org/r/63987/diff/1/?file=1898510#file1898510line48> > > > > After this change, atlas plugin does not have guava jar packaged. Can > > you check that?
It seems, the last change fixed this. - Zsombor ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/#review191624 ----------------------------------------------------------- On Nov. 22, 2017, 12:23 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63987/ > ----------------------------------------------------------- > > (Updated Nov. 22, 2017, 12:23 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-1905 > https://issues.apache.org/jira/browse/RANGER-1905 > > > Repository: ranger > > > Description > ------- > > As ranger-plugins-audit doesn't exclude guava from hadoop common, an older > guava > is leaked into embeddedwebserver classpath, which somehow filtered out by the > assembly plugin. > If we explicitly exclude the old guava, and include the new (17.0) guava in > ranger-plugins-audit module, the generated tar.gz/zip distributions will > contain the necessary guava-17.0.jar in ews/lib path. > > > Diffs > ----- > > agents-audit/pom.xml c8bd1d8f3 > src/main/assembly/plugin-atlas.xml fd988116d > > > Diff: https://reviews.apache.org/r/63987/diff/2/ > > > Testing > ------- > > Tested with executing: > > mvn -DskipTests package assembly:assembly; > unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt > > And comparing the results with different versions. With the patch, the guava > jar appears correctly. > > > Thanks, > > Zsombor Gegesy > >
