----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63995/#review191742 -----------------------------------------------------------
agents-common/src/main/resources/service-defs/ranger-servicedef-gaiandb.json Lines 1 (patched) <https://reviews.apache.org/r/63995/#comment269623> There is an enhanced and documented REST API for ranger-admin. Although the API used for registering the service-def works correctly, it is better to use v2 APIs documented below. https://cwiki.apache.org/confluence/display/RANGER/Apache+Ranger+0.6+-+REST+APIs+for+Service+Definition%2C+Service+and+Policy+Management agents-common/src/main/resources/service-defs/ranger-servicedef-gaiandb.json Lines 2 (patched) <https://reviews.apache.org/r/63995/#comment269625> Madhan used ranger-0.7 to register this service-def, and Ranger Admin shows ‘Masking’ policy tab correctly. Please consider clearing browser cache and trying again. agents-common/src/main/resources/service-defs/ranger-servicedef-gaiandb.json Lines 134 (patched) <https://reviews.apache.org/r/63995/#comment269622> It is generally better to duplicate the resource information from corresponding resource from "resources" section and change those attributes which have different values for resource in "dataMaskDef" section. Although this service-def will be processed correctly and work as expected in deployment, the suggested way is required for in-process unit tests to work correctly. Thus, the "schema" resource here may be specified as follows. "itemId": 1, "name": "schema", "type": "string", "level": 10, "parent": "", "mandatory": true, "lookupSupported": true, "recursiveSupported": false, "excludesSupported": true, "matcher": "org.apache.ranger.plugin.resourcematcher.RangerDefaultResourceMatcher", "matcherOptions": { "wildCard":false, "ignoreCase":true }, "validationRegEx":"", "validationMessage": "", "uiHint":"{ \"singleValue\":true }", "label": "Gaian Schema", "description": "Gaian virtual Schema" }, - Abhay Kulkarni On Nov. 21, 2017, 6:24 p.m., Shi Wang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63995/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2017, 6:24 p.m.) > > > Review request for ranger, Abhay Kulkarni and Madhan Neethiraj. > > > Repository: ranger > > > Description > ------- > > Ranger-1488 Adding GaianDB plugin serviceDef > > > Diffs > ----- > > > agents-common/src/main/resources/service-defs/ranger-servicedef-gaiandb.json > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63995/diff/1/ > > > Testing > ------- > > Used curl -u admin:admin -X POST -H "Accept: application/json" -H > "Content-Type: application/json" \ > -d @ranger-servicedef-gaiandb.json > http://hostname:6080/service/plugins/definitions > > to register and it shows the proper defination on UI, the only problem is the > masking tab is not showing. > > > Thanks, > > Shi Wang > >
