----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64525/#review193662 -----------------------------------------------------------
Ship it! Ship It! - Colm O hEigeartaigh On Dec. 13, 2017, 1:49 a.m., pengjianhua wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64525/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 1:49 a.m.) > > > Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O > hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan > Neethiraj, Velmurugan Periasamy, and Qiang Zhang. > > > Bugs: RANGER-1924 > https://issues.apache.org/jira/browse/RANGER-1924 > > > Repository: ranger > > > Description > ------- > > Simplify ranger-hdfs plugin remove gson.jar in > ranger/src/main/assembly/hdfs-agent.xml and ranger/hdfs-agent/pom.xml > and Simplify ranger-hive plugin remove gson.jar in > ranger/src/main/assembly/hive-agent.xml and ranger/hive-agent/pom.xml > Description: > Remove <include>com.google.code.gson:gson*</include> in > ranger/src/main/assembly/hdfs-agent.xml > Remove <include>com.google.code.gson:gson*</include> in > ranger/src/main/assembly/hive-agent.xml > Remove " <dependency> > <groupId>com.google.code.gson</groupId> > <artifactId>gson</artifactId> > </dependency> " from ranger/hdfs-agent/pom.xml and > ranger/hive-agent/pom.xml > > Reason: > 1.Hadoop already has gson.jar removed from gson.jar to prevent conflicts > 2.Observing ranger-yarn plugin has also removed gson.jar in > ranger/src/main/assembly/plugin-yarn.xml. > 3.Hive already has gson.jar removed from gson.jar to prevent conflicts > > Result: the ranger-hdfs plugin also works fine after removing gson.jar. > the ranger-hive plugin also works fine after removing gson.jar > > > Diffs > ----- > > hdfs-agent/pom.xml 0b6773d > hive-agent/pom.xml c195443 > src/main/assembly/hdfs-agent.xml 5279a9a > src/main/assembly/hive-agent.xml ca65c80 > > > Diff: https://reviews.apache.org/r/64525/diff/2/ > > > Testing > ------- > > Tested it. > > > Thanks, > > pengjianhua > >
